BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

Add spell checker support #76

Open souhaiebtar opened 8 years ago

Rokt33r commented 8 years ago

We're going to replace the current editor, Ace, with Codemirror. After replacing, we might be able to use codemirror-spell-checker . But, It is available only en-US now.

Rokt33r commented 8 years ago

Spellchecking API of chrome doesn't seem to be available yet. https://github.com/electron/electron/issues/3211

kazup01 commented 7 years ago

I will close this because this issue has been left untouched.

mhhennig commented 7 years ago

Please could you reopen this - for me that's an essential missing feature. Thanks!

beta-tank commented 7 years ago

Maybe you can add electron-spellchecker to editor?

goldhand commented 6 years ago

Would be nice as a toggleable setting! Not looking for an auto-correcting solution but highlighting misspellings would be very helpful

Leiknir commented 6 years ago

This will help me as well. Any updates? Thanks!

lylemoffitt commented 6 years ago

I too would like toggleable spellcheck. There are times when the squiggles would be distracting, like when taking notes live in a meeting. But, when drafting it's essential. Even an on-demand pass through aspell or similar would be better than nothing.

dbuskariol commented 6 years ago

This should be revisited–Spell check is a must when writing MD!

ehhc commented 6 years ago

I am working on it :). Though i will not promise anything..

ehhc commented 6 years ago

can you have a look at https://github.com/BoostIO/Boostnote/issues/2176 .. But it is not perfect..

ehhc commented 6 years ago

Hey guys, just a short update: the maintainer of boostnote and i do have a different view on the scope and the implementation of this feature. As i understood it, my PR will not be merged therefore. Sorry to say that but i can't do something about that feature anymore (and due to the huge amount of work i invested into my PR i feel a bit demotivated to try it again using the way the maintainer would like to have it. You can see a part of the discussion here: https://github.com/BoostIO/Boostnote/issues/2176 )

Sorry to let you down but i will not continue to work on it

IssueHuntBot commented 5 years ago

@kazup01 has started working. Visit this issue on Issuehunt

IssueHuntBot commented 5 years ago

@kazup01 has stopped working. Visit this issue on Issuehunt

lundyio commented 5 years ago

This needs to be a thing, I can't believe we're still talking about this. Mutiny?

ehhc commented 5 years ago

Has somebody of you tried the spellcheck that now exist? What do you think about it? Of course not perfect, but as a start point..?

mohamnag commented 5 years ago

which version? is there any? I'm using 0.11.12 and can't find anything regarding this and dont see any functionality while editing.

ehhc commented 5 years ago

you have to enable it in the preferences. There is an option: Preferences > Editor > Enable spellcheck - Experimental feature!! :)

You have to enable it and should notice a spellcheck-dropdown under markdown notes

mohamnag commented 5 years ago

since first time that I activated that check box, saving interface settings gives me the message "An error occured!" even though the settings are saved. this happens wether or not the checkbox is cleared.

as for the spell checking, seems to work except for some lag and corner cases. I would report back if I can reproduce them in a neutral env.

ehhc commented 5 years ago

@mohamnag thanks for the feedback. I have no idea why the error happens :( Yeah.. i know about the lags but don't know how to fix them.. i rely on a spellcheck-lib which i simply use..

mohamnag commented 5 years ago

is there a way to get a low level log from application so that maybe helps with the error on saving the settings?

Rokt33r commented 5 years ago

@modmod24 Did you check devtool? And which OS are you using now?

ehhc commented 5 years ago

@Rokt33r you mean @mohamnag , don't you? :D

@mohamnag you can enable the developer console under View > Toggle Developer Tools... If there are any error messages / low level logs at all, you can find them there :)

mohamnag commented 5 years ago

@Rokt33r the error happened to me while using boostnote on a Mac. I will report back more details when I'm back home but can't reproduce it right now on a Windows machine

Flexo013 commented 5 years ago

Related feature suggestion: #3171

johnnyleitrim commented 5 years ago

@ehhc When I try to save the settings on Mac, I see the following:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
ehhc commented 5 years ago

@johnnyleitrim why do you think it's related to the spellcheck?

johnnyleitrim commented 5 years ago

@ehhc Sorry - I was under the impression you were looking for the logs when trying to save after clicking on spellcheck doesn't work.

you can enable the developer console under View > Toggle Developer Tools... If there are any error messages / low level logs at all, you can find them there :)

ehhc commented 5 years ago

@johnnyleitrim oh, okay. maybe i was back then :) thanks :)

I tried to reproduce your issue and - at least for me - it seams like it's only a warning and not preventing us from doing anything...

Do you also have issues with saving the preferences? Or did you just wondered about the warning?

Pvanduyse commented 3 years ago

Any updates? From the comments, it looks like there was some form of functionality at some point, but I'm not seeing anything in the preferences at the moment. Possibly one of the features that has yet to be ported into the new version?

mohamnag commented 3 years ago

I moved to MarkText, way better, way more functionality (including spell checking) and no forcing towards making profit out of it.

ehhc commented 3 years ago

@Pvanduyse If you're using boostnote (and not the new boostnote next - i don't know anything about that), you have to enable teh spellcheck in preferences: Preferences > Editor > Enable spellcheck - Experimental feature!! :)

After that there is a dropdown to select a language below the writting window

arcturus140 commented 3 years ago

I think this was disabled only to see if there where any performance issues. Perhaps default setting could be reconsidered. Many applications enable spell check per default.