search

BoostIO / boostnote-mobile

Boostnote for iOS and Android 🚀
https://boostnote.io/
MIT License
816 stars 158 forks source link

Upgrade RN + Native Base #89

Closed rmevans9 closed 6 years ago

rmevans9 commented 6 years ago

NOTE: This breaks the bar that should be above the keyboard in the note screen. I played around with a few things to see if I could get it to place nice but it wouldn't. I am thinking it is due to the fact that native-base's Content can end up as a ScrollView then there is a nested ScrollView in the getNoteComponent method.

Personally I would suggest reviewing the structure of most of these screens to remove some of the inline styles, the inline binds (you should not bind within a render method as that creates a new function every render) and cleanup how the views are structured. This would be for another day though.

kazup01 commented 6 years ago

@rmevans9 Thank you :) We will check it later.

kohei-takata commented 6 years ago

@rmevans9 Thanks for your PR! There remains some views to fix style, but I will merge this PR. I do not have a knowledge about inline style. I'm grad if you tell me how to fix.