[BUG] Query filters for SUM column may not work correctly in token holders API - Githubissues

BoostryJP / ibet-Prime

Advanced API Toolkit for Digital Securities Issuance and Management on the ibet Network 🚀

https://ibet.jp/ibet-for-fin

Apache License 2.0

11 stars 1 forks source link

[BUG] Query filters for SUM column may not work correctly in token holders API #647

Closed purplesmoke05 closed 4 months ago

purplesmoke05 commented 4 months ago

Describe the bug

Query filters for SUM columns does not work correctly in token holders API when the SUM column includes NULL value record.

https://github.com/BoostryJP/ibet-Prime/blob/d7b459b022a4f1b94555724da98cfd1931b63b84/app/routers/bond.py#L1874-L1881

https://github.com/BoostryJP/ibet-Prime/blob/d7b459b022a4f1b94555724da98cfd1931b63b84/app/routers/share.py#L1837-L1844

This typically happens because the SUM function ignores NULL values, and if all the values being summed are NULL, the result will also be NULL.
To handle this, we should use the COALESCE function on summed column to replace NULL with 0.

Expected behavior

Use COALESCE function on summed column to replace NULL with 0.