Separate functions that are not related to the issuer - Githubissues

BoostryJP / ibet-Prime

Advanced API Toolkit for Digital Securities Issuance and Management on the ibet Network 🚀

https://ibet.jp/ibet-for-fin

Apache License 2.0

11 stars 1 forks source link

Separate functions that are not related to the issuer #664

Closed YoshihitoAso closed 3 months ago

YoshihitoAso commented 3 months ago

1. Change to store issuer-related and unrelated APIs in separate directories

app > routers > issuer | misc

2. Add environment variables

FREEZE_LOG_FEATURE_ENABLED: Set if you want to use FRREZE-LOG features.
DVP_AGENT_FEATURE_ENABLED: Set if you want to use DVP Paying Agent features.

3. Change to DVP-related APIs

The API used by the paying agent was extracted and redefined.
- For issuer: app.routers.issuer.settlement_issuer.py
- For paying agent: app.routers.misc.settlement_agent.py
Change the specifications for issuer-related APIs to force the issuer address to be set in the header. Data between issuers is now safely separated.
- GET: /settlement/dvp/{exchange_address}/deliveries
- GET: /settlement/dvp/{exchange_address}/delivery/{delivery_id}

YoshihitoAso commented 3 months ago

From the Agent's perspective, there was a problem with referencing the delivery list, so a new API was added. https://github.com/BoostryJP/ibet-Prime/pull/664/commits/17a38ff5dacaf31b224d559bb356930eb51e61ff