BootNodeDev / dAppBooster

A modern blockchain boilerplate built to quickly get you started with your next project.

https://dappbooster.dev

MIT License

5 stars 1 forks source link

fix(chainId type): avoid using @lifi/sdk ChainId to type `chainId` #248

Closed fernandomg closed 3 months ago

fernandomg commented 3 months ago

Closes #223

Description:

Also, I properly narrowed types for values which allowed the removal of type assertions as well.

Steps:

Test by adding networks not supported by lifi that tsc stop complaining.

Type of change:

[ ] New feature
[x] Bug fix
[ ] Breaking change
[ ] Enhancement
[x] Refactoring
[ ] Chore

How Has This Been Tested?

[x] Manual testing
[ ] Automated tests
[ ] Other (explain)

Remember to check that:

Your code follows the style guidelines of this project
You have performed a self-review of your code
You have commented your code in hard-to-understand areas
You have made corresponding changes to the documentation
Your changes generate no new warnings

Screenshots

(Add screenshots or videos to help test this pull request)

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dappbooster	✅ Ready (Inspect)	Visit Preview	Aug 22, 2024 1:52pm