Closed obackhouse closed 1 year ago
FYI @cjcscott I think that ebcc
wasn't actually getting imported in the CI on #92 :grimacing:
I thought we already knew this? Hence lots of skipped tests? Good to run them though - 3.11 a good addition as well, let's see if any bugs gets turned up!
Ah I may have misunderstood, did the ebcc
tests pass locally? Should be fine if so.
I've also edited this PR to drop CI support for python 3.7. It's EOL is in 3 weeks and dyson
specifically requires >=3.8 anyway. I won't change the Vayesta requirements to disallow 3.7 for now, but I don't see much point in CI/CD for python versions past their EOL.
Yeah, I've run tests with ebcc separately when plumbing in the interface etc. No opposition to dropping python 3.7, given eol sounds very sensible!
I'll check what's happening with cvxy
as a dependency here, the nicely skipping tests functionality appears to not be working..
Patch coverage has no change and project coverage change: +0.08
:tada:
Comparison is base (
10db358
) 71.99% compared to head (9601255
) 72.07%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'll check what's happening with
cvxy
as a dependency here, the nicely skipping tests functionality appears to not be working..
I've had trouble getting it to play nicely inside unittest.TestCase
s before, never quite worked out why. I think you could also do
if "cvxpy" not in sys.modules:
pytest.skip("Requires cvxpy")
inside the function body (or the setUpTests
maybe? Maybe not)
I fixed the cvxpy
stuff, this can be merged
The CI did not include a run that builds with none of the optional dependencies. This PR changes the standard runs to now use all optional dependencies, and adds a 'bare' run with none of them. It also drops 3.7 and adds a 3.11 run.