BoothGroup / Vayesta

A Python package for wave function-based quantum embedding
Apache License 2.0
32 stars 7 forks source link

CodeCov Fix Attempt #123

Closed cjcscott closed 1 year ago

cjcscott commented 1 year ago

This attempts to install Vayesta in editable mode within the github CI. This should hopefully fix the codecov (no guarantees) since we seem to actually be encountering a bug with coverage.py itself; for more info see https://github.com/nedbat/coveragepy/issues/1034 or https://stackoverflow.com/questions/72986258/pytest-cov-showing-no-coverage.

It seems like the issue is that since we're installing not in editable mode, we're not technically running the /vayesta repository we specify we want coverage for and so no activity is traced. With any luck being in editable mode fixes this, otherwise I'll investigate something else.

Looking at the coverage bot this started after merging https://github.com/BoothGroup/Vayesta/pull/97 and moving from setup.py to pyproject.toml, so I guess that may have changed this behaviour?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +72.05% :tada:

Comparison is base (583b949) 0.00% compared to head (ca5a30f) 72.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## =========================================== + Coverage 0.00% 72.05% +72.05% =========================================== Files 139 139 Lines 18645 18645 Branches 0 2979 +2979 =========================================== + Hits 0 13435 +13435 + Misses 18645 4467 -14178 - Partials 0 743 +743 ``` [see 131 files with indirect coverage changes](https://app.codecov.io/gh/BoothGroup/Vayesta/pull/123/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.