BoothGroup / Vayesta

A Python package for wave function-based quantum embedding
Apache License 2.0
32 stars 7 forks source link

Bugfix PR: This fixes a bug introduced while re-enabling calculation of rdm1 in variational embedding #127

Closed abhishekkhedkar09 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b63ac15) 71.57% compared to head (217770d) 71.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #127 +/- ## ======================================= Coverage 71.57% 71.57% ======================================= Files 145 145 Lines 19357 19356 -1 Branches 3111 3111 ======================================= Hits 13854 13854 + Misses 4738 4737 -1 Partials 765 765 ``` | [Files Changed](https://app.codecov.io/gh/BoothGroup/Vayesta/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup) | Coverage Δ | | |---|---|---| | [...sc/variational\_embedding/calc\_nonorth\_couplings.py](https://app.codecov.io/gh/BoothGroup/Vayesta/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-dmF5ZXN0YS9taXNjL3ZhcmlhdGlvbmFsX2VtYmVkZGluZy9jYWxjX25vbm9ydGhfY291cGxpbmdzLnB5) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abhishekkhedkar09 commented 1 year ago

so basically the codecov patch shows an error as the tests are skipped. The actual tests have covered the said lines, I checked!