search

BoothGroup / Vayesta

A Python package for wave function-based quantum embedding
Apache License 2.0
33 stars 8 forks source link

Run tests for PRs to all branches. #81

Closed cjcscott closed 1 year ago

cjcscott commented 1 year ago

Updates ci.yaml to triggers tests to run for all PRs, not just for those to master or dev. If this doesn't work to target all PRs we could explicitly filter for all branches within pull_request, but that seems unnecessary if this removes filtering entirely.

obackhouse commented 1 year ago

One side effect of this PR is that @cjcscott will now receive email notifs should the nightly tests fail - @ghb24 if you want these instead, you can push an empty line to the end of the ci.yaml?

Again there is probably some more rigorous way to redirect those emails but there's no trivial solution...

ghb24 commented 1 year ago

One side effect of this PR is that @cjcscott will now receive email notifs should the nightly tests fail - @ghb24 if you want these instead, you can push an empty line to the end of the ci.yaml?

Again there is probably some more rigorous way to redirect those emails but there's no trivial solution...

Done

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (ae4e426) 68.90% compared to head (5c75d5f) 68.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81 +/- ## ========================================== - Coverage 68.90% 68.85% -0.06% ========================================== Files 119 119 Lines 16854 16852 -2 Branches 2463 2404 -59 ========================================== - Hits 11614 11603 -11 - Misses 4526 4538 +12 + Partials 714 711 -3 ``` [see 12 files with indirect coverage changes](https://codecov.io/gh/BoothGroup/Vayesta/pull/81/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.