BoothGroup / ebcc

Coupled cluster models for both purely electron and coupled electron-boson models, with a focus on generality and model extensibility.
https://boothgroup.github.io/ebcc/
MIT License
11 stars 2 forks source link

Refactoring and cleaning #28

Closed obackhouse closed 1 year ago

obackhouse commented 1 year ago

Lots of code cleanup and some minor refactoring to simplify things, improved docstrings, also flake8 linting.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 93.69% and project coverage change: -0.03 :warning:

Comparison is base (47e2058) 99.58% compared to head (ef81d05) 99.56%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #28 +/- ## ========================================== - Coverage 99.58% 99.56% -0.03% ========================================== Files 54 54 Lines 85707 85708 +1 Branches 724 817 +93 ========================================== - Hits 85355 85333 -22 - Misses 237 249 +12 - Partials 115 126 +11 ``` | [Impacted Files](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup) | Coverage Δ | | |---|---|---| | [ebcc/\_\_init\_\_.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9fX2luaXRfXy5weQ==) | `98.73% <ø> (ø)` | | | [ebcc/ansatz.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9hbnNhdHoucHk=) | `80.58% <ø> (-0.19%)` | :arrow_down: | | [ebcc/space.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9zcGFjZS5weQ==) | `91.26% <ø> (ø)` | | | [ebcc/util.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy91dGlsLnB5) | `70.44% <75.47%> (-1.04%)` | :arrow_down: | | [ebcc/rebcc.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9yZWJjYy5weQ==) | `86.09% <89.58%> (-1.31%)` | :arrow_down: | | [ebcc/reom.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9yZW9tLnB5) | `94.30% <97.22%> (+0.08%)` | :arrow_up: | | [ebcc/uebcc.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy91ZWJjYy5weQ==) | `96.79% <97.24%> (-0.67%)` | :arrow_down: | | [ebcc/brueckner.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9icnVlY2tuZXIucHk=) | `90.69% <100.00%> (+0.10%)` | :arrow_up: | | [ebcc/dump.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9kdW1wLnB5) | `86.17% <100.00%> (-0.96%)` | :arrow_down: | | [ebcc/eris.py](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup#diff-ZWJjYy9lcmlzLnB5) | `86.07% <100.00%> (+0.36%)` | :arrow_up: | | ... and [4 more](https://app.codecov.io/gh/BoothGroup/ebcc/pull/28?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BoothGroup) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.