search

Bootwhmcs / bootwhmcs

Template files for Bootwhmcs
75 stars 42 forks source link

Used placeholder #59

Closed mikk150 closed 10 years ago

mikk150 commented 10 years ago

Simple modifications to bootWHMCS to use placeholders, because putting values in makes things little akward, if not handeled correctly.

N6REJ commented 10 years ago

I'd like to see visual differentiation between the two methods. Placeholder is just a tooltip, and you've removed the alternate language insertion on if fail, so i'd like to see visually whats gained/changed by your code.

mikk150 commented 10 years ago

there is no visual difference, only usability difference. BootWHMCS is quite bad on usability right now. I'm going to backport many usability fixes on BootWHMCS, that fix many issues for ordering proccess and buttons and other things... so there are more merge requests coming

ghost commented 10 years ago

Not much time an effort has been put into the order form, unfortunately. It was just quickly created as an example to go with.

Tho, i can't really see how you have improved or done anything in these commits besides removing language text and changing the order of the labels?

N6REJ commented 10 years ago

I think you should show images of what your speaking of cause I don't know of the issues. like " i had no colors" , explain. as far as I can tell its fine.

N6REJ commented 10 years ago

There is something wrong with your install of bootwhmcs I've tried the language change and as you can see it works fine here. turk capture

ghost commented 10 years ago

The pictures you are showing clearly indicate an issue with the background colors on all statuses besides "Terminated"

N6REJ commented 10 years ago

ah, I didn't realize there should be other colors... Logical now that I think about it. I did a little ( and still am ) research and it seems the $Service.rawstatus is not being pulled for anything BUT terminated

ghost commented 10 years ago

It's a silly spelling issue, all statuses should work besides "active".

@mikk150 If you can update your code to revert back to my original code and change the if line from $service.rawstats to $service.rawstatus on the "active" part, then it should solve the issue.

Re-commit and update your merge request and i will implement the changes.

N6REJ commented 10 years ago

great catch freddy, I just spent 2hrs trying to figure this out. Hate spelling errors. I can confirm that fixes it. fixed

mikk150 commented 10 years ago

should be it