BoraxTheClean / adaptable-antelopes

Code Jam 2021 adaptable antelopes team
MIT License
1 stars 0 forks source link

Re-focus cursor to ok button after display file's content. #37

Closed ntdkhiem closed 3 years ago

ntdkhiem commented 3 years ago

Making it easier for the user to add the file to the text editor.

Also, I don't know why my branch has 22 commits ahead of main.

BoraxTheClean commented 3 years ago

I'm getting some inconsistency with this. When I open a directory, sometimes it foucses on the ../ button, sometimes it focuses on cancel

ntdkhiem commented 3 years ago

I can re-focus the cursor to the cancelbutton instead of ../ button.

BoraxTheClean commented 3 years ago

Making it easier for the user to add the file to the text editor.

Also, I don't know why my branch has 22 commits ahead of main.

After this gets merged run:

git checkout main
git pull
git branch -D scroll_menu

Typically you run into issues like this when you reuse one branch name for multiple features.

It won't cause any problems for this change, it just muddies the git history.

BoraxTheClean commented 3 years ago

I can re-focus the cursor to the cancelbutton instead of ../ button.

My gripe was that it is inconsistent. Here is a Loom of me encountering this bug: https://www.loom.com/share/35cdc85571db4e16a5aa5287aeb6ff4e

Let me know if this is me doing something wrong?

ntdkhiem commented 3 years ago

I was able to re-produce this bug. I made it to always focuses on ../ button

BoraxTheClean commented 3 years ago

@ntdkhiem Actually, should we update the docs for this change before you merge?