search

BoraxTheClean / adaptable-antelopes

Code Jam 2021 adaptable antelopes team
MIT License
1 stars 0 forks source link

Refactor All the Things 🧹 😄 ❗ #48

Closed ntdkhiem closed 3 years ago

ntdkhiem commented 3 years ago
  1. Moved application states into application/
  2. Decoupled dialogs into one folder
  3. Refactored text_editor into two classes: ThoughtBox (main) and MenuNav (sub)
    • The file definitely can be refactored more but I don't know where to put it.
  4. I didn't delete old files because I'm not confident in my code yet.
  5. make those reviews rain !!!!!
BoraxTheClean commented 3 years ago
  1. Moved application states into application/
  2. Decoupled dialogs into one folder

  3. Refactored text_editor into two classes: ThoughtBox (main) and MenuNav (sub)

    • The file definitely can be refactored more but I don't know where to put it.
  4. I didn't delete old files because I'm not confident in my code yet.
  5. make those reviews rain !!!!!
  1. Those dialogs can go into text and scroll respectively.
  2. ThoughtBox should go in Application. MenuNav ????
  3. 🔪 Them
ntdkhiem commented 3 years ago
  1. Those dialogs can go into text and scroll respectively.
  2. ThoughtBox should go in Application. MenuNav ????
  3. 🔪 Them

Those dialogs inherited from PopUpDialog so shouldn't they stay in that folder? or I can make text and scroll inside custom_types

ntdkhiem commented 3 years ago

Could @CupOfGeo or @BoraxTheClean review my 2 new commits before I merge this PR? thanks :))