do_save_as_file not saving

BoraxTheClean / adaptable-antelopes

Code Jam 2021 adaptable antelopes team

MIT License

1 stars 0 forks source link

do_save_as_file not saving #54

Closed ghost closed 3 years ago

ghost commented 3 years ago

I've been unable to save a file to a user-specified path. I think the problem is among the conditions of the if block in do_save_as_file. Line 132 is:

and os.path.isfile(user_entered_path)

but the os.path documentation says isfile checks if a path exists, so I believe it's failing on valid paths that don't point to a file.

I don't see an easy fix, but this might be useful.

CupOfGeo commented 3 years ago

just comment it out for now and but maybe join it with application states.current_path

BoraxTheClean commented 3 years ago

This seems to be fixed, do we want to close?