Borda / keras-yolo3

A Keras implementation of YOLOv3 (Tensorflow backend) a successor of qqwweee/keras-yolo3
MIT License
31 stars 10 forks source link

port to TensorFlow 2.0 #34

Closed 6293 closed 4 years ago

6293 commented 4 years ago

Replaced deprecated modules and functions.

pep8speaks commented 4 years ago

Hello @z8674558! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:80: E501 line too long (103 > 79 characters) Line 229:80: E501 line too long (80 > 79 characters) Line 476:80: E501 line too long (84 > 79 characters) Line 487:80: E501 line too long (85 > 79 characters) Line 493:80: E501 line too long (86 > 79 characters) Line 494:80: E501 line too long (110 > 79 characters) Line 501:80: E501 line too long (86 > 79 characters) Line 585:80: E501 line too long (98 > 79 characters) Line 586:80: E501 line too long (98 > 79 characters)

Line 602:80: E501 line too long (87 > 79 characters) Line 637:80: E501 line too long (94 > 79 characters) Line 638:80: E501 line too long (94 > 79 characters)

Line 20:80: E501 line too long (101 > 79 characters)

Line 24:80: E501 line too long (101 > 79 characters)

Comment last updated at 2020-06-04 09:47:32 UTC
Borda commented 4 years ago

@z8674558 thx, it seems that also test need to be adjusted according to new returns values as this change is not back-compatible to TF 1, mind also update min TF version in requirements

6293 commented 4 years ago

@Borda okay, I will modify the test.

codecov[bot] commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 0%. The diff coverage is 72%.

@@         Coverage Diff          @@
##           master   #34   +/-   ##
====================================
  Coverage      74%   74%           
====================================
  Files           6     6           
  Lines         854   851    -3     
====================================
- Hits          630   629    -1     
+ Misses        224   222    -2     
6293 commented 4 years ago

@Borda modified tox.ini, requirements.txt and .travis.yml to pass the tests. Also, I fixed docstring to pass doctest.

Borda commented 4 years ago

@z8674558 Thank you!