Closed Borda closed 3 years ago
Merging #32 (012ad1b) into master (2ef3348) will increase coverage by
0%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #32 +/- ##
=====================================
Coverage 96% 97%
=====================================
Files 16 16
Lines 3971 3976 +5
=====================================
+ Hits 3832 3837 +5
Misses 139 139
Hello @Borda! Thanks for updating this PR.
Line 212:111: E501 line too long (116 > 110 characters) Line 469:111: E501 line too long (118 > 110 characters) Line 711:111: E501 line too long (120 > 110 characters) Line 754:111: E501 line too long (115 > 110 characters) Line 784:111: E501 line too long (115 > 110 characters)
Line 74:111: E501 line too long (120 > 110 characters) Line 108:111: E501 line too long (115 > 110 characters)
imsegm/ellipse_fitting.py
:Line 98:111: E501 line too long (116 > 110 characters) Line 101:111: E501 line too long (116 > 110 characters) Line 104:111: E501 line too long (117 > 110 characters)
may be fixed by https://github.com/Borda/pyGCO/pull/22 as the error is the same:
____________________ ERROR collecting imsegm/graph_cuts.py ____________________
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\gco\__init__.py:5: in <module>
from pygco import * # noqa: F401 F403
E ModuleNotFoundError: No module named 'pygco'
During handling of the above exception, another exception occurred:
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\gco\pygco.py:7: in <module>
from cgco import _cgco, _SMOOTH_COST_FN
E ModuleNotFoundError: No module named 'cgco'
During handling of the above exception, another exception occurred:
imsegm\graph_cuts.py:13: in <module>
from gco import cut_general_graph
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\gco\__init__.py:7: in <module>
from gco.pygco import * # noqa: F401 F403
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\gco\pygco.py:9: in <module>
from .cgco import _cgco, _SMOOTH_COST_FN
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\gco\cgco.py:46: in <module>
_cgco = np.ctypeslib.load_library(_CGCO_LIB_NAME, _CGCO_LIB_PATH)
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\numpy\ctypeslib.py:150: in load_library
return ctypes.cdll[libpath]
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\ctypes\__init__.py:423: in __getitem__
return getattr(self, name)
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\ctypes\__init__.py:418: in __getattr__
dll = self._dlltype(name)
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\ctypes\__init__.py:348: in __init__
self._handle = _dlopen(self._name, mode)
E OSError: [WinError 193] %1 is not a valid Win32 application
____________________ ERROR collecting imsegm/pipelines.py _____________________
C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\gco\__init__.py:5: in <module>
from pygco import * # noqa: F401 F403
E ModuleNotFoundError: No module named 'pygco'
Description
adding testing also for Windows, need to be fixed
Type of change
Please delete options that are not relevant.
Checklist: