search

BorderTech / wcomponents

Accessible Web UI Framework for Enterprise
GNU General Public License v3.0
21 stars 17 forks source link

Port redirect off of XML/XSLT #1841

Closed philipcaisip closed 3 months ago

philipcaisip commented 3 months ago

Removes client-side redirects off of the XSLT registration scripts. Uses HTML custom elements, like #1837.

Currently it seems to be functionally correct but the code does define the redirect tag in two different spots (one in WrongStepAjaxInterceptor and one in ContentRenderer). This likely ought to be in one spot but I wasn't sure which one spot.

philipcaisip commented 3 months ago

Hi @ricksbrown, I've made those changes that you mentioned. Regarding the red TSC errors though, I couldn't see any. There are a few yellow warnings but they look unavoidable/minor (just complaining about some weird Jasmine syntax and the mock window). Is this fine?

ricksbrown commented 3 months ago

Hi @ricksbrown, I've made those changes that you mentioned. Regarding the red TSC errors though, I couldn't see any. There are a few yellow warnings but they look unavoidable/minor (just complaining about some weird Jasmine syntax and the mock window). Is this fine?

Yes, it's more a general point. They probably got sorted out when you cleaned up the code a bit.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ricksbrown commented 3 months ago

LGTM - you can merge it when you are ready. EDIT: I'm doing the merge for you, because I want to merge another after that without causing you merge hell.