search

Borewit / music-metadata

Stream and file based music metadata parser for node. Supporting a wide range of audio and tag formats.
MIT License
900 stars 90 forks source link

Certain MPC files fail to parse #1041

Closed LudekStoklasa closed 2 years ago

LudekStoklasa commented 2 years ago

These three MPC files fail to parse/read metadata (and takes more than 16 seconds to parse them on i7):

Other apps read the tag metadata correctly.

MousePack support originally added as https://github.com/Borewit/music-metadata/issues/165

Borewit commented 2 years ago

It takes my old i7 based PC.1.850 second to parse these 3 files.

Due to the way music-metadata parses file, which is reading from beginning to the end for stream compliance in combination with way Musepack is build up, this is very expensive.

The error is thrown as result of the APEv2 header is specifying a tag with a reserved data type.

I will create a patch to register a warning instead of throwing an error.

Borewit commented 2 years ago

You should no longer have this error from version > v7.12.2 @LudekStoklasa.

LudekStoklasa commented 2 years ago

Thanks!