codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 68.96% and project coverage change: +0.24 :tada:
Comparison is base (
7264162) 56.63% compared to head (786e6e1) 56.87%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #184 +/- ## ========================================== + Coverage 56.63% 56.87% +0.24% ========================================== Files 43 44 +1 Lines 1492 1519 +27 ========================================== + Hits 845 864 +19 - Misses 647 655 +8 ``` | Flag | Coverage Δ | | |---|---|---| | pytest | `56.87% <68.96%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/BorgwardtLab/proteinshake/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab) | Coverage Δ | | |---|---|---| | [proteinshake/datasets/protein\_family.py](https://codecov.io/gh/BorgwardtLab/proteinshake/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab#diff-cHJvdGVpbnNoYWtlL2RhdGFzZXRzL3Byb3RlaW5fZmFtaWx5LnB5) | `38.09% <66.66%> (+3.09%)` | :arrow_up: | | [proteinshake/tasks/pfam\_task.py](https://codecov.io/gh/BorgwardtLab/proteinshake/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab#diff-cHJvdGVpbnNoYWtlL3Rhc2tzL3BmYW1fdGFzay5weQ==) | `68.00% <68.00%> (ø)` | | | [proteinshake/tasks/\_\_init\_\_.py](https://codecov.io/gh/BorgwardtLab/proteinshake/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab#diff-cHJvdGVpbnNoYWtlL3Rhc2tzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BorgwardtLab):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Almost the same as EC task, just changed the
add_protein_attributes()inProteinFamilyDatasetto store the ID and not the name so will require a build.Eventually we should also do a check that all the labels we grab are from the same Pfam version as I noticed there is a version tag in the annotations..