search

BoringCode / TranslateThis

A simple addon for Firefox that translates text using Google Translate
https://addons.mozilla.org/en-US/firefox/addon/translate-this/
Mozilla Public License 2.0
32 stars 8 forks source link

Please add support for Multiprocess #16

Closed Red-Squid closed 8 years ago

Red-Squid commented 8 years ago

Firefox is evolving, please adapt this add-on to keep it valid. Thanks!

https://wiki.mozilla.org/Electrolysis

BoringCode commented 8 years ago

Have you personally tested it with the dev builds?

I haven't done that yet, but my understanding was that if I used standard Addon SDK APIs (which I have) that the addon should support multi-process Firefox out of the box.

Red-Squid commented 8 years ago

don't know specifically, it's flagged as not compatible by Addon Compatibility Reporter... a tool that's suggested for people who want to see if there add-ons are compatible with e10s/multiprocess in the new FF.

FF will default to e10s = off if add-ons aren't compatible; unless it's forced on, which can break things.

Should probably be rewritten in WebExtension format anyway, makes it pretty much plug 'n' play on other browsers too. ; )

On Tue, Sep 13, 2016 at 6:38 PM, Bradley Rosenfeld <notifications@github.com

wrote:

Have you personally tested it with the dev builds?

I haven't done that yet, but my understanding was that if I used standard Addon SDK APIs (which I have) that the addon should support multi-process Firefox out of the box.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BoringCode/TranslateThis/issues/16#issuecomment-246848500, or mute the thread https://github.com/notifications/unsubscribe-auth/APY3Qk289sDIBDEr25_dHK4LLzgGQJAZks5qpyYCgaJpZM4J8ODj .

rmbleeker commented 8 years ago

I can confirm that this add-on is indeed not compatible with multiprocess on Firefox 49 https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

BoringCode commented 8 years ago

Apparently I misread the docs and incorrectly set the multiprocess in package.json. I tested it in Firefox Nightly and multiprocess appears to be working fine.

Version 3.5.1 has been uploaded to the AMO for review, hopefully it will be pushed to users soon.