search

Boris-Em / BEMCheckBox

Tasteful Checkbox for iOS. (Check box)
MIT License
2.63k stars 287 forks source link

iOS 10 Warning: Assigning to 'id<CAAnimationDelegate> _Nullable' from incompatible type 'BEMCheckBox *const __strong' #25

Closed Signoo closed 8 years ago

Signoo commented 8 years ago

I've just downloaded XCode 8.2 and the compiler returns this warning: Assigning to 'id<CAAnimationDelegate> _Nullable' from incompatible type 'BEMCheckBox *const __strong' In each line where you set the delegate inside the addOnAnimation function.

I just found it out and posted it here, if I found a solution i'll let you know

Signoo commented 8 years ago

Ok actually it was easy to fix, in BEMCheckBox.h I just had to replace the line: IB_DESIGNABLE @interface BEMCheckBox : UIView with: IB_DESIGNABLE @interface BEMCheckBox : UIView <CAAnimationDelegate>

Boris-Em commented 8 years ago

HI @Signoo, Would you mind submitting a pull request with your work? Thank you!

Signoo commented 8 years ago

Hi @Boris-Em I've created the pull request, It's my first one so hopefully I did nothing wrong :)

Btw thanks for this awesome library!

Boris-Em commented 8 years ago

Closed as fixed with #30. Thank you for opening this issue and fixing it @Signoo!

iTofu commented 7 years ago

Thanks for @Signoo ! It works for me!