search

Boris-Em / BEMSimpleLineGraph

Elegant Line Graphs for iOS. (Charting library)
MIT License
2.66k stars 382 forks source link

Swift conflicts with deprecated protocol methods #262

Open AvdLee opened 8 years ago

AvdLee commented 8 years ago
screen shot 2016-05-04 at 09 15 32

This result in an annoying error, which can be fixed by implementing the datasource callback as followed: 

func lineGraph(graph: BEMSimpleLineGraphView, labelOnXAxisForIndex index: Int) -> String
Sam-Spencer commented 8 years ago

It looks like the lineGraph:labelOnXAxisForIndex: was originally implemented on BEMSimpleLineGraphDelegate, but is now implemented on BEMSimpleLineGraphDataSource.

This issue has been reported previously and is fixed on the feature branch in commit 83e8acd7efa4657258c1320442d5f59953bdc710. Duplicate of #214.

The feature branch has not yet been merged due to breaking changes that need to be tested and announced. If it's not too difficult for your workflow, I would recommend adopting these changes.