BorisMolo / JavaFx

Learnng Java language
1 stars 1 forks source link

Button logic, method/variable naming, organization #5

Open jnwlkr opened 5 years ago

jnwlkr commented 5 years ago

Line 24: timer never used locally Line 32: variable naming conventions: could timeStartAnimationTimer be just startTimer or startAnimationTimer? Line 33: variable naming and spelling: same as above (timePreviosAnimationTimer too long, spelling) change to lastTimer? prevTimer? previousAnimationTimer? Line 37: Same as above Line 38: variable naming: secondsAnimationTimer = secTimer? secondsTimer? secAnimationTimer?

Lines 49-53: We need to rename and reorganize)

Replace Russian that is displayed to a user with English translation. Even with Russian language pack on my computer, I cannot see any of your Cyrillic characters when I run program, or edit in Eclipse. They are nonsense characters - it is odd.

More to come.