Preserve line breaks

[mathewpeterson]

Line breaks are not preserved when being outputed.

What should be outputed (note the line breaks):

\n ${TotalPayments}

<tr>   <td class="tblsubframecontent" align="center"><input name="date[1]" id="date_1" size="10" value="1/1/11" type="text"></td>   <td class="tblsubframecontent" align="center"><input name="amount[1]" id="amount_1" size="10" value="22.2" type="text"></td>   <td class="tblsubframecontent"></td>  </tr><tr>   <td class="tblsubframecontent" align="center"><input name="date[2]" id="date_2" size="10" value="1/1/11" type="text"></td>   <td class="tblsubframecontent" align="center"><input name="amount[2]" id="amount_2" size="10" value="22.2" type="text"></td>   <td class="tblsubframecontent"></td>  </tr><tr>   <td class="tblsubframecontent" align="center"><input name="date[3]" id="date_3" size="10" value="1/1/11" type="text"></td>   <td class="tblsubframecontent" align="center"><input name="amount[3]" id="amount_3" size="10" value="22.2" type="text"></td>   <td class="tblsubframecontent"></td>  </tr><tr>   <td class="tblsubframecontent" align="center"><input name="date[4]" id="date_4" size="10" value="1/1/11" type="text"></td>   <td class="tblsubframecontent" align="center"><input name="amount[4]" id="amount_4" size="10" value="22.2" type="text"></td>   <td class="tblsubframecontent"></td>  </tr>

[Kissaki]

There is no input type textbox. http://www.w3.org/TR/html401/sgml/dtd.html#InputType

You are probably looking for ?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mathewpeterson"><img src="https://avatars.githubusercontent.com/u/203190?v=4" />mathewpeterson</a> commented <strong> 14 years ago</strong> </div> <div class="markdown-body"> <p>No, it was text.. However, that isnt the point. The actual generated output by this plugin does not preserve the line breaks that are in the template. I have the examples in this but github isnt recognizing the code..</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/coiscir"><img src="https://avatars.githubusercontent.com/u/15981?v=4" />coiscir</a> commented <strong> 14 years ago</strong> </div> <div class="markdown-body"> <p>Is it safe to assume you mean the markup itself is not formatted when returned?</p> <p>If so, why would it need to be? Considering it's generated content, is there really any benefit to having it come out <em>pretty</em>? Any further interaction with the resulting markup would normally be through the UI it creates or an element inspector (such as that in Firebug or Chrome) which display the DOM in a tree structure.</p> <p>Am I missing something?</p> <p>BTW: Indent your code by 4 spaces on every line to have it print out properly in your comments. See the docs for GitHub Flavored Markdown -- link at the bottom-right, under the comment textarea.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Kissaki"><img src="https://avatars.githubusercontent.com/u/93181?v=4" />Kissaki</a> commented <strong> 14 years ago</strong> </div> <div class="markdown-body"> <p>In those input[type=text] it wouldn’t matter, but for <pre>-style blocks it would.</p> <p>But I dunno if he was referring to that, as he didn’t seem to …</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mathewpeterson"><img src="https://avatars.githubusercontent.com/u/203190?v=4" />mathewpeterson</a> commented <strong> 14 years ago</strong> </div> <div class="markdown-body"> <p>@coiscir: Yes, you are correct. I believe this plugin should preserve the line breaks that are in the template. I don't want to be dependent on some third party plugin to auto-format my source code. It's much faster for me to ctrl+a ctrl+u to view my source. </p> <p>@Kissaki: Again, it's not the value of the input I am talking about, merely the line breaks between the tags.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/kof"><img src="https://avatars.githubusercontent.com/u/52824?v=4" />kof</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>@coiscir I have 4 points about it:</p> <ul> <li>as @kissaki already said about pre tags</li> <li>template engine shouldn't modify markup in places user doesn't expect it. I think the correct behaviour is also not to prettify the output, but to leave it as it is.</li> <li>practical example would be: if I want to debug the generated markup, I want to see its string representation, not a rendered by browser dom view, because its not the same. So if you cut the new lines etc. its all 1 line then and is difficult to read.</li> <li>another use case: I maintain nodejs port of jquery-tmpl, <a href="https://github.com/kof/node-jqtpl">https://github.com/kof/node-jqtpl</a>, html is rendered serverside and the output is always 1 line, which is difficult to inspect without to render it by browser and then use firebug. </li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Kissaki"><img src="https://avatars.githubusercontent.com/u/93181?v=4" />Kissaki</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Indeed, a template function should only do that, templating, and not more logic like minimizing. It should only do so if a parameter or the function(name) indicates it is also minifying.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/defunctzombie"><img src="https://avatars.githubusercontent.com/u/84792?v=4" />defunctzombie</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>imho this is a very serious issue that doesn't seem to be getting any attention? Is there some reason that a simple fix isn't available? Seems like it wouldn't be too bad (but I don't know).</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ghost"><img src="https://avatars.githubusercontent.com/u/10137?v=4" />ghost</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>I want this as well, but for different reasons. I'm appending my output to a textarea and was expecting my linebreaks in my template to go over to my textarea. As it is right now it's all on a single line. Only way to work around this in the current state is to have separate templates for each section with manual line breaks inserted at the end. Be a lot nicer if white space was preserved.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mathewpeterson"><img src="https://avatars.githubusercontent.com/u/203190?v=4" />mathewpeterson</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>I do believe the issue is here: <a href="https://github.com/jquery/jquery-tmpl/blob/master/jquery.tmpl.js#L326">https://github.com/jquery/jquery-tmpl/blob/master/jquery.tmpl.js#L326</a></p> <p>Not able to test at the moment, let me know if anyone can confirm this.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/BorisMoore"><img src="https://avatars.githubusercontent.com/u/202658?v=4" />BorisMoore</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Yes, you are right. That line was there from the beginning - in John Resig's original prototype. It reflects the philosophy that the goal it to guarantee HTML visual layout, but not to preserve 'pretty printing' or similar of HTML. </p> <p>We can consider changing that philosophy. I agree that there are scenarios where it is valuable to maintain that fidelity. I am happy to keep this issue, open, (so will open it again now), particularly as I am planning to make rendering to an HTML string a lot easier to achieve in the Beta2 version. (We hope to release a Beta2 in April.)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Kissaki"><img src="https://avatars.githubusercontent.com/u/93181?v=4" />Kissaki</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Allowing for pruning via a parameter(/option) would be a viable solution.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alandecastros"><img src="https://avatars.githubusercontent.com/u/147017?v=4" />alandecastros</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>what happenned to this issue? is it solved?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/clarabstract"><img src="https://avatars.githubusercontent.com/u/2922?v=4" />clarabstract</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>@BorisMoore - how can the content of <code><pre></code> or <code><textarea></code> tags not considered as part of the HTML visual layout? </p> <p>Why does the plugin bother stripping out the original linebreaks anyway? What purpose does that serve exactly?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/BorisMoore"><img src="https://avatars.githubusercontent.com/u/202658?v=4" />BorisMoore</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Several reasons, such as that in the conversion to code, for creating a compiled function, line breaks can lead to JS errors, missing string delimiters, etc. Supporting them would have added additional code for compilation.</p> <p>In the ongoing work at <a href="https://github.com/BorisMoore/jsrender">JsRender</a> and <a href="https://github.com/BorisMoore/jsviews">JsViews</a> I am currently working on a different compilation approach which may allow me to provide a mode that preserves white space.... (See <a href="https://github.com/jquery/jquery-tmpl/issues/96">https://github.com/jquery/jquery-tmpl/issues/96</a> for context re: roadmap).</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/clarabstract"><img src="https://avatars.githubusercontent.com/u/2922?v=4" />clarabstract</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Oh right I forgot JS doesn't really roll with multiline strings. Having said that, why not a trivial fix like so:</p> <pre><code class="language-diff">diff --git a/data/js/jquery/other/jquery.tmpl.js b/data/js/jquery/other/jquery.tmpl.js index 213d136..cc5ee0c 100644 --- a/data/js/jquery/other/jquery.tmpl.js +++ b/data/js/jquery/other/jquery.tmpl.js @@ -323,7 +330,9 @@ // Convert the template into pure JavaScript jQuery.trim(markup) .replace( /([\\'])/g, "\\$1" ) - .replace( /[\r\t\n]/g, " " ) + .replace( /\n/g, "\\n") + .replace( /\r/g, "\\r") + .replace( /\t/g, "\\t") .replace( /\$\{([^\}]*)\}/g, "{{= $1}}" ) .replace( /\{\{(\/?)(\w+|.)(?:\(((?:[^\}]|\}(?!\}))*?)?\))?(?:\s+(.*?)?)?(\(((?:[^\}]|\}(?!\}))*?)\))?\s*\}\}/g, function( all, slash, type, fnargs, target, parens, args ) {</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rdworth"><img src="https://avatars.githubusercontent.com/u/107824?v=4" />rdworth</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Thanks for taking the time to submit this issue. Just wanted to let you know this plugin is no longer being actively developed or maintained by the jQuery team. See README for more info.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/catamphetamine"><img src="https://avatars.githubusercontent.com/u/477167?v=4" />catamphetamine</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>You should fix this issue</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>