search

BorisMoore / jsviews

Interactive data-driven views, MVVM and MVP, built on top of JsRender templates
http://www.jsviews.com/#jsviews
MIT License
857 stars 130 forks source link

cannot use 'data-xxxx' attribute in data-link with commit 64 #306

Closed shimooka closed 9 years ago

shimooka commented 9 years ago

Hi Boris !

I've created a sample fiddle : http://jsfiddle.net/shimooka/fdLsjk40/

You will see two text, 'attrs' and 'data'. The 'attrs' text (in p tag) has 'attr-xxxx' attributes but 'data' doesn't have 'data-xxxx' attributes . I use JsViews with bootstrap modal dialog, and want to use with 'data-toggle' and 'data-target' attributes.

If with JsViews commit 63, it works well.

Thanks.

BorisMoore commented 9 years ago

Thanks for calling this out. I am on vacation, but when I return in about a week's time, I'll look into this.

BorisMoore commented 9 years ago

Yes, this is a bug. The fix is simply to remove the two lines:

https://github.com/BorisMoore/jsviews/blob/master/jsviews.js#L3227-L3228.

I'll include that fix in the next update.

shimooka commented 9 years ago

Thanks a lot !

BorisMoore commented 9 years ago

This has been fixed with Commit 65.

shimooka commented 9 years ago

Hi Boris.

I've checked my fiddle again and worked fine ! Thanks your great work :-)