search

BorisMoore / jsviews

Interactive data-driven views, MVVM and MVP, built on top of JsRender templates
http://www.jsviews.com/#jsviews
MIT License
856 stars 130 forks source link

Regression: checkbox widget not working since v1.0.0 #419

Closed firedaemon-cto closed 5 years ago

firedaemon-cto commented 5 years ago

The checkbox widget doesn't work anymore - when clicking on the checkbox it just doesn't update the model (the other way around seems to work properly).

Here's a fiddle, but also your sample page exhibits the same problem (clicking on the toolbar checkboxes).

This is probably correlated: An observable change wasn't reflected by v.0.9.91 while it now is in v.1.0.2. See this fiddle testing an observable update.

BorisMoore commented 5 years ago

Thanks very much for calling this out. Yes, it is a bug in jsviews-jqueryui-widgets.js.

I'll fix it in the next update.

For now, can you test out adding the following line immediately after the line https://github.com/BorisMoore/jsviews.com/blob/gh-pages/download/sample-tag-controls/jsviews-jqueryui-widgets.js#L275

  mainElement: "input",
  linkedElement: "input", // Add this line

Let me know if you see any issues after making this change...

Thanks again...

BorisMoore commented 5 years ago

The fix is included in the new v1.0.3 release.