search

BorisOsipov / reportportal-js-client

Apache License 2.0
2 stars 4 forks source link

feature: add support for custom headers #13

Closed moredhel closed 4 years ago

moredhel commented 4 years ago

It is not possible to attach custom headers (such as when accessing behind cloudflare). This adds support for such a use-case.

BorisOsipov commented 4 years ago

@moredhel Do you need new releases of this client and wdio reporter with these changes or you use this package internally?

moredhel commented 4 years ago

Hi Boris,

I would appreciate a version bump as we are depending on it through your other project:

https://github.com/BorisOsipov/wdio-reportportal-service

Specifically:

https://github.com/BorisOsipov/wdio-reportportal-service/blob/master/package-lock.json#L3915

Looking at the two repos, it looks like the versions are out of sync:

reportportal-js-client (1.2.0) wdio-reportportal-service (1.2.1)

perhaps I should bump this up to 1.2.2 to force an update in the other repo

On 31 Jan 2020, at 16:11, Boris Osipov notifications@github.com wrote:

@moredhel https://github.com/moredhel Do you need new releases of this client and wdio reporter with these changes or you use this package internally?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BorisOsipov/reportportal-js-client/pull/13?email_source=notifications&email_token=AANJKXHXHM2SSDS73MG37VTRAQ5RNA5CNFSM4KOIEVZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKO6FAI#issuecomment-580772481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJKXHTPDQJ3WH7F4TS4ILRAQ5RNANCNFSM4KOIEVZA.

BorisOsipov commented 4 years ago

Ok will bump packages

BorisOsipov commented 4 years ago

@moredhel release it. please, check

moredhel commented 4 years ago

Hi Boris,

it still says last release was 2 months ago on the npmjs.com site:

https://www.npmjs.com/package/reportportal-js-client

Thanks for being so quick with this!

On 31 Jan 2020, at 16:58, Boris Osipov notifications@github.com wrote:

@moredhel https://github.com/moredhel release it. please, check

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BorisOsipov/reportportal-js-client/pull/13?email_source=notifications&email_token=AANJKXHFDS4AWP3RK6XZOGTRARDCZA5CNFSM4KOIEVZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPC26A#issuecomment-580791672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJKXFDQAFVY6WTVHFTDG3RARDCZANCNFSM4KOIEVZA.

moredhel commented 4 years ago

I see you have updated wdio repo too, I assume it is propogating & will follow this up on Monday morning.

Thanks again

moredhel

On 31 Jan 2020, at 17:00, moredhel notifications@github.com wrote:

Hi Boris,

it still says last release was 2 months ago on the npmjs.com site:

https://www.npmjs.com/package/reportportal-js-client

Thanks for being so quick with this!

On 31 Jan 2020, at 16:58, Boris Osipov notifications@github.com wrote:

@moredhel https://github.com/moredhel release it. please, check

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BorisOsipov/reportportal-js-client/pull/13?email_source=notifications&email_token=AANJKXHFDS4AWP3RK6XZOGTRARDCZA5CNFSM4KOIEVZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPC26A#issuecomment-580791672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJKXFDQAFVY6WTVHFTDG3RARDCZANCNFSM4KOIEVZA.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BorisOsipov/reportportal-js-client/pull/13?email_source=notifications&email_token=AANJKXA7JT7NENVBWBSO4ZTRARDJNA5CNFSM4KOIEVZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPDBQQ#issuecomment-580792514, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANJKXFWTC7RNO5GV4ZP7UDRARDJNANCNFSM4KOIEVZA.

BorisOsipov commented 4 years ago

Ok. Thank you too!