search

BorisPolonsky / dify-helm

Deploy langgenious/dify, an LLM based app on kubernetes with helm chart
MIT License
205 stars 52 forks source link

(feat) Add support for smtp config #52

Closed filipechagas closed 7 months ago

filipechagas commented 7 months ago

Add Support for SMTP config

If api.mail.type eq smtp, it'll allow the definition of smtp config env vars.

https://docs.dify.ai/getting-started/install-self-hosted/environments#mail-related-configuration

BorisPolonsky commented 7 months ago

Thanks for your contribution. I wonder if it's a good idea to substitute .Values.api.mail.smtp.* pattern for .Values.api.mail.smtp in this section, what do you think? Meanwhile, it's advised to update .Values.yaml as well to make this feature explicit. A dummy example with comments will be helpful.

filipechagas commented 7 months ago

@BorisPolonsky Makes sense. Thank you for the feedback. I've applied the suggestions - did the same for resend moving it from api.mail.resendApi* to api.mail.resend.api*. LMK what you think.

BorisPolonsky commented 7 months ago

LGTM. We are closed to merging this PR. It's also advised to make this value boolean instead of string and substitute {{ .Values.api.mail.smtp.useTLS | quote } for {{ .Values.api.mail.smtp.useTLS | toString | quote }. Just like MILVUS_SECURE does.

filipechagas commented 7 months ago

@BorisPolonsky Good thinking. Done f2c1b33e20d1a48f1361afa5bef16942008766cd