search

BorisPolonsky / dify-helm

Deploy langgenious/dify, an LLM based app on kubernetes with helm chart
MIT License
130 stars 29 forks source link

(fix) Add CONSOLE_WEB_URL to web and worker containers #54

Closed filipechagas closed 3 months ago

filipechagas commented 3 months ago

This env var is also required in the web container when sending emails:

https://github.com/langgenius/dify/blob/94d04934b3aa943fce8ad9dfc5c9982e1375bab5/api/tasks/mail_invite_member_task.py#L32C42-L32C57

BorisPolonsky commented 3 months ago

Thanks for your contribution. You may wish to create a PR in the official dify repo as well since their docker-compose.yaml does not come with this environment variable in section worker. https://github.com/langgenius/dify/blob/94d04934b3aa943fce8ad9dfc5c9982e1375bab5/docker/docker-compose.yaml#L17C7-L17C22

I've searched CONSOLE_WEB_URL in the official repo and found no reference for it in web. Maybe it's not necessary for web component?

filipechagas commented 3 months ago

@BorisPolonsky you're absolutely correct, it's only needed in the worker. Thank you for spotting that.

I'll also make sure to open a PR on dify's official docker-compose.