search

BorisPolonsky / dify-helm

Deploy langgenious/dify, an LLM based app on kubernetes with helm chart
MIT License
177 stars 46 forks source link

Support Aliyun OSS #74

Closed denverdino closed 3 months ago

denverdino commented 4 months ago

Support Alibaba Cloud OSS as external storage

BorisPolonsky commented 4 months ago

Thanks for your contribution. I'm currently very busy and my k8s dev environment went down hence I have to review this later. Sorry for the delay.

BorisPolonsky commented 3 months ago

LGTM. Since we need to further adjust some comments and precedence of the configuration in .Values.yaml and we have other features that need to be overhauled, could you please merge into dev branch instead? Thank you.

denverdino commented 3 months ago

Thanks for your review. I changed the base branch to dev.

BorisPolonsky commented 3 months ago

@denverdino Could you please confirm if OSS were officially supported by dify. There's no such environment variables in their exemplar docker-compoese.yaml

denverdino commented 3 months ago

@BorisPolonsky Yes, it is defined in https://github.com/langgenius/dify/blob/main/api/config.py#L245

And examples in https://github.com/langgenius/dify/blob/main/api/.env.example#L57

and I tested it for a while and fixed few issues months ago. https://github.com/langgenius/dify/pull/4425

BorisPolonsky commented 3 months ago

Noted. It would be advisable if you would also add these configuration to their docker-compose.yaml as we aim to maintain compatibility based on that file.

denverdino commented 3 months ago

https://github.com/langgenius/dify/pull/5366

The PR has been merged.