search

BornToBeRoot / check_nextcloud

Nagios/Centreon plugin for nextcloud serverinfo API (https://github.com/nextcloud/serverinfo)
GNU Affero General Public License v3.0
32 stars 15 forks source link

Python3 support #15

Closed waja closed 2 years ago

waja commented 4 years ago

Hi there,

as Python2 is not maintained anymore, is there a chance to get this plugin migrated over to Python3? Fedora and Debian dropping support for Python2 too.

Many thanks, Jan.

BornToBeRoot commented 4 years ago

PRs are welcome :)

I tried to migrate to Python 3 but i doesn't want to maintain both version. Maybe now is the time. I would create a separate branch for 2.7 and the master would be on 3

Here is some code for Python 3 https://github.com/BornToBeRoot/check_nextcloud/commit/8ef9b437146d4524af147a28fa8d160fe0dedbc7

waja commented 3 years ago

Here is some code for Python 3 8ef9b43

Is there a reason why you rolled this back code again?

BornToBeRoot commented 3 years ago

Sry for my late reply. There was no reason... i didn't want to maintain both versions.

I can migrate to Python3 when I have the need or some free time. PRs are also welcome.

waja commented 2 years ago

I'm not very familiar with python, but https://www.stxnext.com/blog/python-3-migration-guide/ seems to have a nice lazy point of start.