search

Boruch-Baum / emacs-crossword

Play/Download crossword puzzles in Emacs
GNU General Public License v3.0
67 stars 4 forks source link

Title: Suggested Fix For Issue 9 #10

Closed tvraman closed 3 years ago

tvraman commented 3 years ago

Description: The present solution lives poorly with other packages that also use advice, see previous issue #9. A simple fix would be to declare the _n and _p args to the advicer function as optional, this would also let you eliminate the need for different advice-lambdas for emacs 27 vs 28 (given that you ignore the args in both cases). #

Boruch-Baum commented 3 years ago

Thank you. Your fix is correct per the emacs28 docstring for self-insert-command, so although I can't reproduce the issue in #9, I've applied a relevant patch in 474e330. Please verify that all is good now.