BorysLevytskyi / BitwiseCmd

Bitwise Calculator Online
http://bitwisecmd.com
GNU Affero General Public License v3.0
315 stars 14 forks source link

Including parentheses in input causes a hang #51

Closed ayesc9000 closed 1 year ago

ayesc9000 commented 1 year ago

The following input:

0b0000000000000000001000010001011110000010100000001 & (0b0000000000000000001000010001011110000010100000001 >> 7)

will cause the page to hang and become unresponsive. Excluding parentheses will fix the issue.

I am aware that parentheses are not supported in BitwiseCmd, but there should probably be a check in place to display an error message rather than causing the page to freeze :P

BorysLevytskyi commented 1 year ago

Hi, Liam.

Thanks for letting me know. The issue has been fixed.

On Tue, May 23, 2023 at 2:19 AM Liam Hogan @.***> wrote:

The following input:

0b0000000000000000001000010001011110000010100000001 & (0b0000000000000000001000010001011110000010100000001 >> 7)

will cause the page to hang and become unresponsive. Excluding parentheses will fix the issue.

I am aware that parentheses are not supported in BitwiseCmd, but there should probably be a check in place to display an error message rather than causing the page to freeze :P

— Reply to this email directly, view it on GitHub https://github.com/BorysLevytskyi/BitwiseCmd/issues/51, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3OKMVN6RWJKH2B77KHRZTXHP7AFANCNFSM6AAAAAAYLDSIWQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ayesc9000 commented 1 year ago

Awesome, thanks Borys.

On May 25, 2023 7:46:15 a.m. EDT, Borys Levytskyi @.***> wrote:

Hi, Liam.

Thanks for letting me know. The issue has been fixed.

On Tue, May 23, 2023 at 2:19 AM Liam Hogan @.***> wrote:

The following input:

0b0000000000000000001000010001011110000010100000001 & (0b0000000000000000001000010001011110000010100000001 >> 7)

will cause the page to hang and become unresponsive. Excluding parentheses will fix the issue.

I am aware that parentheses are not supported in BitwiseCmd, but there should probably be a check in place to display an error message rather than causing the page to freeze :P

— Reply to this email directly, view it on GitHub https://github.com/BorysLevytskyi/BitwiseCmd/issues/51, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3OKMVN6RWJKH2B77KHRZTXHP7AFANCNFSM6AAAAAAYLDSIWQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Reply to this email directly or view it on GitHub: https://github.com/BorysLevytskyi/BitwiseCmd/issues/51#issuecomment-1562761566 You are receiving this because you authored the thread.

Message ID: @.***>