search

Boscop / web-view

Rust bindings for webview, a tiny cross-platform library to render web-based GUIs for desktop applications
MIT License
1.92k stars 175 forks source link

Windows-EDGE frameless fixes #231

Closed Blakeinstein closed 2 years ago

Blakeinstein commented 4 years ago

This implements a border less frame, Currently I have a 2px margin for resizing and can implement a method to set the same. I have no idea how Mshtml implementation works now, the code is getting hard to understand...

I can create a seperate PR to also implement the DRAG_WINDOW method I use on https://github.com/Blakeinstein/Bloop along with cross-platform implements. I dont have testing platform for linux and macos anymore. So if anyone can tell me how frameless looks on the same, I will look into it aswell.

I have started this PR as a discussion platform first.

richardhozak commented 3 years ago

The changes look fine, but this would definitely need to be implemented for mshtml also, for me to accept it. I am not sure but I think other platforms do not have any problems with borderless windows.

Blakeinstein commented 3 years ago

I was talking about the edges, and resizing in other platforms, I am confused how resizing works on mshtml, i will look into it first

FrankenApps commented 3 years ago

I think a method to set the border width would be great.

Blakeinstein commented 3 years ago

I agree! But should that function do nothing on linux and mac?

FrankenApps commented 3 years ago

Something like setWindowsBorderWidth could be an option.

Blakeinstein commented 3 years ago

The function name isnt a problem, I am wondering about what it would do on other platforms. Do you want me to make it useless on other platforms? Should I add my dragwindow function as well? So that you can have the window drageable?