BossHobby / QUICKSILVER

Flight Controller Firmware
MIT License
176 stars 42 forks source link

correct set point scaling in deg/s #97

Closed bw1129 closed 1 year ago

bw1129 commented 1 year ago

Hi guys. I am trying to get PIDtoolbox to accurately read QS logfiles. The main issue I am seeing is that set point as extracted from the logfiles (BF converted log) is not in deg/s and doesnt seem to take into account rates, though I cant be sure, so I dont think it's a simple linear scaling. I tried dividing setpoint/10 and it is closer but certainly not correct. Be great if this was corrected then I can implement PTB tuning protocol for those interested. (plot below shows current set point (red) vs gyro (black), with SP/10, which is clearly not working; motor sigs also not scaled correctly there but that will be a simple linear re-scaling that I can do on my end) image

bkleiner commented 1 year ago

fix in https://github.com/BossHobby/Configurator/commit/df148e7f4c13cb5b5d98d566de1446c2af91c9e9