search

BossHuso / discord-rare-drop-notificater

Sends a detailed notification via Discord webhooks whenever you get a rare/unique drop.
BSD 2-Clause "Simplified" License
17 stars 42 forks source link

Missing info #50

Closed 0anth closed 2 years ago

0anth commented 2 years ago

Since around the 28th January, the item information line including the item name, quality and source has stopped being posted. Issue seems to have happened to everyone in our group that uses the plugin around the 28th/29th January.

Before 28th January: before

After 28th January: after

MathieuDR commented 2 years ago

This should be fixed since yesterday. Can you confirm?

0anth commented 2 years ago

This was resolved seems to be happening again.

Embedded posts are missing info and non embedded are coming through as null.

Please see screenshot below.

Screenshot 2022-03-23 153442

MathieuDR commented 2 years ago

Yet, this is because OSRS Box is shut down and currently unavaiable which has the same symptoms. I'm currently working on fixing it through the outputted JSON / database.

0anth commented 2 years ago

Ahh right. I'm not sure what data you were pulling from OSRS Box, but have you looked at the RuneLite web API? You can pull a decent amount of data on items and NPCs with their API.

MathieuDR commented 2 years ago

Hmm, not really. as it was originally developped with osrsbox. My current plan was to completly omit the api call. But i'll take a look at the RL Api to see if there is anything worth staying with an API call

MathieuDR commented 2 years ago

Do you have a link to said API?

0anth commented 2 years ago

I looked, but it turns out RL took down their public http api a few months back.

OSRS wiki does have an API available for prices (https://oldschool.runescape.wiki/w/RuneScape:Real-time_Prices) and RL still offers image caches (http://static.runelite.net/cache/item/icon/995.png).

MathieuDR commented 2 years ago

The prices might actually be interesting. At the moment it's working. If you experience any issue still. Please open up a new ticket