search

BossHuso / discord-rare-drop-notificater

Sends a detailed notification via Discord webhooks whenever you get a rare/unique drop.
BSD 2-Clause "Simplified" License
17 stars 40 forks source link

Rarity of loot on multiple tables is not calculated correctly #82

Open jack0lantern opened 1 year ago

jack0lantern commented 1 year ago

My buddy kept getting rune spear notifications from basilisk knights because the plugin thinks the rarity is 1/13312. But the item is on 2 tables, the main roll is 1/52, and then the gem table has it at 1/13312

So the rarity should actually be 1/52 + 1/13312

iProdigy commented 1 year ago

Example logic to account for multiple drop rates: https://github.com/iProdigy/DinkPlugin/blob/88331ec8f35cface89444d6c4575a0e5127c439e/src/main/java/dinkplugin/util/NpcDropTable.java#L33-L40