making it work with phpspec ~3.2

BossaConsulting / phpspec2-expect

Helper that decorates any SUS with a PhpSpec lazy object wrapper

MIT License

75 stars 34 forks source link

making it work with phpspec ~3.2 #38

Closed andho closed 7 years ago

andho commented 7 years ago

Currently the compatibility for phpspec2-expect is up to phpspec ~3.1. Waiting for release compatible with phpspec ~3.2.

andho commented 7 years ago

I see that master branch supports phpspec >= 3.2.0 < 3.3.0. But I don't see tests for new matchers:

TriggerMatcher
IterateMatcher
ApproximatelyMatcher

Also does it mean < 3.2.0 is no longer supported and if supporting < 3.2.0, how to handle tests for the above 3 new Matchers which are not available for < 3.2.0.

andho commented 7 years ago

@MarcelloDuarte ping.

mlopes commented 7 years ago

@andho would PR #39 fix this?

andho commented 7 years ago

@mlopes yeah that looks good.

mlopes commented 7 years ago

Thanks, going to merge it and close this ticket then.