Bot-Rakshit / bm_frontend

Frontend repository of Samay Raina's chess community website
https://www.bmsamay.com/
MIT License
96 stars 55 forks source link

Added bulletin-board and sidebar fix. #118

Closed krushna06 closed 1 month ago

krushna06 commented 1 month ago

Note: Make sure to change line 10 https://github.com/krushna06/bm_frontend/commit/28aef5a7296d5c1008421861d94acdb7e4d72fd2#diff-aa8d3dcf0514f41721be63e9f4e5addfec720ca7cbb7bd2dcca1a66a7b1c2d11

vercel[bot] commented 1 month ago

@krushna06 is attempting to deploy a commit to the BM-Samay Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bm-frontend- ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 11:20pm
Bot-Rakshit commented 1 month ago

Fix the errors received on build, unused imports

krushna06 commented 1 month ago

don't merge, recoding the sidebar

krushna06 commented 1 month ago

the mobile view is broken so... just wait

krushna06 commented 1 month ago

@Bot-Rakshit Try to merge it now, the build errors are fixed and I've reverted the sidebar to the original version and I'll reocde a newer sidebar in some time with the animation fix for https://github.com/Bot-Rakshit/bm_frontend/issues/117. I think for now you should just remove the animation completely. Just add hover animation on the options

Bot-Rakshit commented 1 month ago

I dont see if the sidebar is broken can u add a screen recording/image for me to understand the exact problem

krushna06 commented 1 month ago

Check https://github.com/Bot-Rakshit/bm_frontend/issues/117 for video and https://i.imgur.com/vgqrh3o.png

Bot-Rakshit commented 1 month ago

for now im not adding bulletin-board on the sidebar. Will discuss with people and see how do we want to this, do we go ahead with a third party forums page or build our own

krushna06 commented 1 month ago

Yeah, I feel the same about creating our own bulletin board. Let's use this temporarily.

krushna06 commented 1 month ago

But tbh, I don't get the point of creating our own when we can use disqus.