search

Bot-detector / Bot-Detector-Core-Files

The server and processing files for the Bot Detector Plugin
GNU General Public License v3.0
18 stars 15 forks source link

breakdown & confidence none by default #442

Closed extreme4all closed 2 years ago

extreme4all commented 2 years ago

afbeelding tests passed

Cyborger1 commented 2 years ago

Confidence should always be null when stats too low, no?

As it is, this commit does not resolve my request.

extreme4all commented 2 years ago

Confidence should always be null when stats too low, no?

No, when breakdown=false, & stats_too_low, no predictions will be shown and the confidence is null

if the user configures to have the breakdown he will receive the predictions

Cyborger1 commented 2 years ago

No, when breakdown=false, & stats_too_low, no predictions will be shown and the confidence is null

You're describing the code you wrote, what I'm saying if there's a misunderstanding on the functional requirement I asked for.

When the label is Stats Too Low, confidence should be always null as it's irrelevant. The breakdown can still be provided even if the primary confidence is null.

How about instead you give me a new boolean field that indicates if the label is valid? (For now, a flag if label == stats too low). Would that work?