The change to line 391 in core.py is to correct a bug based on capitalized vendors as the Hardware Acceleration Whitepaper requested when it currently only presents lowered ffmpeg tags. The server side implementation should support capitalized cases this weekend so this change will need to be reverted and in the windows section of hwi.py the lower() will also need removed or a .capitalize() will need to be added. This will be a separate PR as it is not the current state of things.
The lshw implementation relies on 2 functions. The run lshw func and the check_ven func. For the get_ram_info func I didn't find a need to make a memory units func as it is only done once.
Current implementation does not check for inclusion of required parameters except for gpu["vendor"] I plan to try to develop a catch that will see if the required variables are present and if they aren't to let the user know and exit the program as a fail. However, I think lshw should output what I need well enough for the current dev needs.
The change to worker.py probably shouldn't have been made..... I was messing around with how subprocess worked and was trying to see what could be needed. Should be a quick fix to just remove that text arg but I didn't think it would hurt anything :eyes:
These changes will add Linux support using lshw.
The change to line 391 in core.py is to correct a bug based on capitalized vendors as the Hardware Acceleration Whitepaper requested when it currently only presents lowered ffmpeg tags. The server side implementation should support capitalized cases this weekend so this change will need to be reverted and in the windows section of hwi.py the
lower()will also need removed or a.capitalize()will need to be added. This will be a separate PR as it is not the current state of things.The lshw implementation relies on 2 functions. The run lshw func and the check_ven func. For the get_ram_info func I didn't find a need to make a memory units func as it is only done once.
Current implementation does not check for inclusion of required parameters except for
gpu["vendor"]I plan to try to develop a catch that will see if the required variables are present and if they aren't to let the user know and exit the program as a fail. However, I think lshw should output what I need well enough for the current dev needs.The change to worker.py probably shouldn't have been made..... I was messing around with how subprocess worked and was trying to see what could be needed. Should be a quick fix to just remove that text arg but I didn't think it would hurt anything :eyes:
Let me know if there are any problems!