BotBotMe / botbot-bot

The IRC bot for BotBot.me
https://lincolnloop.com/blog/saying-goodbye-botbotme/
BSD 3-Clause "New" or "Revised" License
231 stars 23 forks source link

Recursion causes trouble #32

Open tianon opened 9 years ago

tianon commented 9 years ago

So, uhh, we (#docker-maintainers) did a bad thing: https://botbot.me/freenode/docker-maintainers/msg/34051580/ :angel:

I wasn't sure exactly which repo to report on, but this one seemed the most appropriate for this specific issue of BotBot recursing on its own comments.

See https://github.com/docker/docker/issues/11360 for the issue we used to cause such trouble -- we eventually had to kick the bot, so help getting it to rejoin would be appreciated, and I've changed the title of that naughty issue back (as you can see in the logs on it) to make sure we don't do it again.

Relevant log bits:

19:47:30 +icecrime:> !m gh#11360
19:47:31 +[d__d]:> !m Sorry I gotta test this: https://github.com/docker/docker/issues/11360
19:47:32 +[d__d]:> You're doing good work, gh#11360!
19:47:33 +[d__d]:> You're doing good work, Sorry I gotta test this: https://github.com/docker/docker/issues/11360!
19:47:34 +[d__d]:> !m Sorry I gotta test this: https://github.com/docker/docker/issues/11360
19:47:35 +[d__d]:> You're doing good work, Sorry I gotta test this: https://github.com/docker/docker/issues/11360!
...
19:51:45 @tianon:> !m gh#11360
19:51:45 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:46 +[d__d]:> You're doing good work, gh#11360!
19:51:48 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:48 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:49 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:50 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:51 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:53 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:53 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:54 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:56 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:56 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:57 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:58 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:59 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:00 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:01 @tianon:> oops ;)
19:52:01 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:02 +duglin:> oh please!
19:52:02 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:04 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:05 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:05 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:06 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:08 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:08 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:09 +duglin:> LOL
19:52:09  <-- tianon has kicked [[d__d]] from #docker-maintainers ([d__d])
icecrime commented 9 years ago

Sorry, I just had the urge to try something stupid after a long day, and didn't want to cause any trouble :-(

paultag commented 9 years ago

bug of the year :dancer:

mtrythall commented 9 years ago

Man, that's neat.

It's late where I am now but I'll help you get your bot back tomorrow and figure out how to get this fixed soon. Ideally BotBot just ignores himself. Have to tackle this ASAP.

tianon commented 9 years ago

@mtrythall cool, thanks; getting our bot back tomorrow is just fine :+1:

Glad you're not mad! :innocent: