search

BotDanny / react-stacked-center-carousel

A responsive, performant, well animated, swipeable, center mode carousel that stacks its slide
33 stars 12 forks source link

Update for React 17 #8

Closed Ostojic-96 closed 2 years ago

Ostojic-96 commented 2 years ago

Is it possible to use it with React 17 without option --legacy-peer-deps ?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: rsg@3.0.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from react-stacked-center-carousel@1.0.8
npm ERR! node_modules/react-stacked-center-carousel
npm ERR!   react-stacked-center-carousel@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
BotDanny commented 2 years ago

Updated to React 18

BotDanny commented 2 years ago

Please update to version 1.0.9

OstojicI commented 2 years ago

Now it needs react-dom 18

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: rsg@3.0.0
npm ERR! Found: react-dom@18.2.0
npm ERR! node_modules/react-dom
npm ERR!   react-dom@"^18.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react-dom@"^16.13.1" from react-stacked-center-carousel@1.0.9
npm ERR! node_modules/react-stacked-center-carousel
npm ERR!   react-stacked-center-carousel@"^1.0.9" from the root project
BotDanny commented 2 years ago

Updated react-dom to 18 as well. Please update to version 1.0.10