search

BotMill / fb-botmill

A Java framework for building bots on Facebook's Messenger Platform.
MIT License
72 stars 26 forks source link

Logging #124

Open kravchenko-rn opened 7 years ago

kravchenko-rn commented 7 years ago

@alvin-reyes fb-botmill logs everything to console. Can I make it put logs in a file? Thanks in advance.

alvin-reyes commented 7 years ago

Yes. We've been planning to do this for a while, so yeah it would be an awesome addition.

Please create a Pull Request once its done and set me as reviewer.

On Thu, Jun 8, 2017 at 6:30 AM Roman Kravchenko notifications@github.com wrote:

@alvin-reyes https://github.com/alvin-reyes fb-botmill logs everything to console. Can I make it to put logs in a file? Thanks in advance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BotMill/fb-botmill/issues/124, or mute the thread https://github.com/notifications/unsubscribe-auth/AERYw_qeY1xq5nbxa2oorp6f73-7TJjlks5sB81VgaJpZM4Nz4Lv .

andrefsore commented 7 years ago

I would suggest not to pack logback.xml in the jar file. Let the user decide where and what to log

alvin-reyes commented 7 years ago

@andrefsore , do you have any suggestion how can we do it better?

andrefsore commented 7 years ago

The developer who imports the lib, should create theirs own logback.xml. I had to create logback-test.xml in order to override logback.xml that was packed in fb-botmil.jar, because I wanted to set the logging level by myself, for instance.