BotWithUs / AbyssAPI

3 stars 8 forks source link

Bank class cleanup #14

Closed Cipher27 closed 1 year ago

ccarpenter04 commented 1 year ago

I get the gist of it but can you provide more information on the goal here?

Cipher27 commented 1 year ago
  1. cleaning up some code that was reused all over the file
  2. withdraw method, in its current state, is likely to iterate over many items instantly if the filter detects more than one for any reason. Issue is already fixed by Java for deposit, just replicating here
  3. deprecated the foreach loop, no longer used