search

Botfuel / botfuel-dialog

Botfuel SDK to build highly conversational chatbots
https://docs.botfuel.io
Other
102 stars 18 forks source link

refactor: The dialogWillComplete hook can no longer return null #201

Closed yangeorget closed 6 years ago

yangeorget commented 6 years ago

BREAKING CHANGE: The dialogWillComplete hook can no longer return null. It should instead return a dialog action such as this.complete().

codecov[bot] commented 6 years ago

Codecov Report

Merging #201 into master will increase coverage by 0.04%. The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   89.09%   89.13%   +0.04%     
==========================================
  Files          78       78              
  Lines        1559     1565       +6     
  Branches      199      197       -2     
==========================================
+ Hits         1389     1395       +6     
- Misses        144      145       +1     
+ Partials       26       25       -1
Impacted Files Coverage Δ
packages/botfuel-dialog/src/dialogs/base-dialog.js 100% <100%> (ø) :arrow_up:
packages/botfuel-dialog/src/dialogs/void-dialog.js 100% <100%> (ø) :arrow_up:
packages/botfuel-dialog/src/dialogs/dialog.js 100% <100%> (ø) :arrow_up:
...ckages/botfuel-dialog/src/dialogs/prompt-dialog.js 96.93% <83.33%> (+1.14%) :arrow_up:
.../botfuel-dialog/src/dialogs/confirmation-dialog.js 91.66% <83.33%> (-8.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b61f5b3...20994f1. Read the comment docs.

KevinDepuydt commented 6 years ago

todo: warn developer when dialogWillComplete does not return anything