search

Botfuel / botfuel-dialog

Botfuel SDK to build highly conversational chatbots
https://docs.botfuel.io
Other
102 stars 18 forks source link

changed name of getLastConversation for lastConversation #205

Closed JosselinMorau closed 6 years ago

JosselinMorau commented 6 years ago

The problem was about the ambiguity of the 'getLastConversation' method's name since traditionally a getter method doesn't alter the state of an object. The name was changed to 'lastConversation' and a line in the doc was added to explain what happens if the last conversation isn't valid anymore.

codecov[bot] commented 6 years ago

Codecov Report

Merging #205 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files          78       78           
  Lines        1578     1578           
  Branches      202      202           
=======================================
  Hits         1400     1400           
  Misses        151      151           
  Partials       27       27
Impacted Files Coverage Δ
packages/botfuel-dialog/src/brains/memory-brain.js 100% <100%> (ø) :arrow_up:
packages/botfuel-dialog/src/brains/brain.js 96.55% <100%> (ø) :arrow_up:
packages/botfuel-dialog/src/brains/mongo-brain.js 97.43% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac88a07...e71c6aa. Read the comment docs.

JosselinMorau commented 6 years ago

Used the name 'fetchLastConversation' instead as Yan requested.