search

Botfuel / botfuel-dialog

Botfuel SDK to build highly conversational chatbots
https://docs.botfuel.io
Other
102 stars 18 forks source link

improvement/spellchecking-error-handling #220

Closed KevinDepuydt closed 6 years ago

KevinDepuydt commented 6 years ago

Before we were triggering the catch-dialog in botfuel-nlu when the spellchecking, the entity extraction or the classification failed.

Now we are handling spellchecking error separately to be able to return the original sentence and let the bot continue is execution without triggering the catch-dialog if the error is not related to authentication.

codecov[bot] commented 6 years ago

Codecov Report

Merging #220 into master will increase coverage by 0.22%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   88.01%   88.23%   +0.22%     
==========================================
  Files          80       80              
  Lines        1585     1590       +5     
  Branches      201      202       +1     
==========================================
+ Hits         1395     1403       +8     
+ Misses        161      158       -3     
  Partials       29       29
Impacted Files Coverage Δ
packages/botfuel-dialog/src/nlus/botfuel-nlu.js 83.11% <90%> (+5.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edd2d92...79eb37b. Read the comment docs.