search

Botfuel / botfuel-dialog

Botfuel SDK to build highly conversational chatbots
https://docs.botfuel.io
Other
102 stars 18 forks source link

SDK handle input too long ➕ #226

Closed yangeorget closed 6 years ago

yangeorget commented 6 years ago

Issue: -when a big utterance is entered, any of our 3 services can crash and crash the bot or UI -we need to set a common min of 3 services and enforce it

Solution:

SDK TEAM: 1.Make the input length check in the SDK. Don't call the services if message is too long but trigger the complex input dialog. (limit 256 chars)

  1. Prevent users from entering long sentences in playgrounds + test panel (same everywhere)

NLP TEAM: Implement a check on all services that return an error if input is too long (trainer api classify included).

yangeorget commented 6 years ago

➤ Sander commented:

Maxime Khoy Sounds like also, we do not need “botfuel-complex-input dialog” anymore.

yangeorget commented 6 years ago

➤ Kevin commented:

Related PR https://github.com/Botfuel/botfuel-dialog/pull/245