search

Botspot / Pi-Power-Tools

General Purpose Raspbian Image & SD Card Manager
GNU General Public License v3.0
191 stars 24 forks source link

Workaround unable to make root fs in image during backup #26

Closed NoozAbooz closed 3 years ago

NoozAbooz commented 3 years ago

Fixes this error: https://cdn.discordapp.com/attachments/839507782088130570/845443367717306368/unknown.png

I am testing it right now, will respond back after my backup completes if the backup works or not. I am a filesystem noob so no idea if it'll work or not or if it's best practice.

NoozAbooz commented 3 years ago

Sweet! I tried booting the backup and it worked flawlessly!

Botspot commented 3 years ago

To be honest, I can't even comprehend the change you made. This is all RonR's code anyway.

NoozAbooz commented 3 years ago

To be honest, I can't even comprehend the change you made. This is all RonR's code anyway.

I think it doesn't matter since rsync expands the block anyways to start writing sd card stuff to it.

NoozAbooz commented 3 years ago

Humm... What is your blocksize?

Botspot commented 3 years ago

Okay, that makes more sense.

I think my root partition's blocksize is 4096. What that means, I have no idea. :)

NoozAbooz commented 3 years ago

Okay, that makes more sense.

I think my root partition's blocksize is 4096. What that means, I have no idea. :)

Yea it looks like it's the default... dunno why my OS is like this then. Only thing I can think of is something with TwisterOS itself or perhaps RPI Imager during flashing.

NoozAbooz commented 3 years ago

Weird sidenote:

stat -fc %s /dev/mmcblk0p2 will say my blocksize is 4096 sudo blockdev --getbsz /dev/mmcblk0p2 will say 512

NoozAbooz commented 3 years ago

@Botspot Can you merge please? I don't think it will cause any harm considering the resulting image is expanded and everything boots up fine in vdesktop.

Botspot commented 3 years ago

I'll just have to trust you on this one, as I never had the opportunity to test it.

NoozAbooz commented 3 years ago

I'll just have to trust you on this one, as I never had the opportunity to test it.

I did "test it" sorta. I used PPT with my fix to generate the amogOS images, and they boot up fine: https://github.com/jostroOS/amogOS/releases/download/1.3.1/AmogOSv1.3.1.xz. Haven't gotten complaints of it not booting other than fstab issues so it's all good.

Botspot commented 3 years ago

Please look at this error report by Beiop on Discord and decide if this merged PR caused it, or would fix it. https://discord.com/channels/770629697909424159/770629941733621760/855617072746725376

NoozAbooz commented 3 years ago

Please look at this error report by Beiop on Discord and decide if this merged PR caused it, or would fix it. https://discord.com/channels/770629697909424159/770629941733621760/855617072746725376

Looks from it due do how PPT is made, the update didn't go through or something and ppt never told the end-user an update was available. To apply it you need to git pull the newest code.

Botspot commented 3 years ago

Please look at this error report by Beiop on Discord and decide if this merged PR caused it, or would fix it. https://discord.com/channels/770629697909424159/770629941733621760/855617072746725376

Looks from it due do how PPT is made, the update didn't go through or something and ppt never told the end-user an update was available. To apply it you need to git pull the newest code.

Okay. I've updated PPT's version number so now all recent changes should be distributed to everyone.